netdev - Re: [PATCH 1/6] net: vlan: rename NETIF_F_HW_VLAN_* feature flags to NETIF_F_HW_VLAN_CTAG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 19 Apr 2013 21:07:17 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Patrick McHardy <kaber@...sh.net>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/6] net: vlan: rename NETIF_F_HW_VLAN_* feature flags
 to NETIF_F_HW_VLAN_CTAG_*

On Fri, 2013-04-19 at 14:04 +0200, Patrick McHardy wrote:
> Rename the hardware VLAN acceleration features to include "CTAG" to indicate
> that they only support CTAGs. Follow up patches will introduce 802.1ad
> server provider tagging (STAGs) and require the distinction for hardware not
> supporting acclerating both.
> 
> Signed-off-by: Patrick McHardy <kaber@...sh.net>
[...]
> --- a/net/core/ethtool.c
> +++ b/net/core/ethtool.c
> @@ -60,10 +60,10 @@ static const char netdev_features_strings[NETDEV_FEATURE_COUNT][ETH_GSTRING_LEN]
>  	[NETIF_F_IPV6_CSUM_BIT] =        "tx-checksum-ipv6",
>  	[NETIF_F_HIGHDMA_BIT] =          "highdma",
>  	[NETIF_F_FRAGLIST_BIT] =         "tx-scatter-gather-fraglist",
> -	[NETIF_F_HW_VLAN_TX_BIT] =       "tx-vlan-hw-insert",
> +	[NETIF_F_HW_VLAN_CTAG_TX_BIT] =  "tx-vlan-ctag-hw-insert",
>  
> -	[NETIF_F_HW_VLAN_RX_BIT] =       "rx-vlan-hw-parse",
> -	[NETIF_F_HW_VLAN_FILTER_BIT] =   "rx-vlan-filter",
> +	[NETIF_F_HW_VLAN_CTAG_RX_BIT] =  "rx-vlan-ctag-hw-parse",
> +	[NETIF_F_HW_VLAN_CTAG_FILTER_BIT] = "rx-vlan-ctag-filter",
>  	[NETIF_F_VLAN_CHALLENGED_BIT] =  "vlan-challenged",
>  	[NETIF_F_GSO_BIT] =              "tx-generic-segmentation",
>  	[NETIF_F_LLTX_BIT] =             "tx-lockless",
[...]

The only stable userland identifiers for these features are their names.
So this is a userland ABI change and I don't think it's acceptable.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html