netdev - Re: [PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 22:46:55 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	Eric Dumazet <eric.dumazet@...il.com>
cc:	Simon Horman <horms@...ge.net.au>,
	Hans Schillstrom <hans@...illstrom.com>,
	Pablo Neira Ayuso <pablo@...filter.org>,
	lvs-devel@...r.kernel.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org,
	Wensong Zhang <wensong@...ux-vs.org>
Subject: Re: [PATCH ipvs-next] ipvs: Remove
 rcu_read_unlock();rcu_read_lock();


	Hello,

On Thu, 25 Apr 2013, Eric Dumazet wrote:

> On Thu, 2013-04-25 at 22:36 +0900, Simon Horman wrote:
> 
> > Ok, leaving it seems reasonable.
> > Pablo, do you have any objections?
> 
> I have objections.
> 
> I would _add_ a cond_resched() there to explicitly do what we want
> 
> Maybe a macro/inline doing this already exists.
> 
> static void inline cond_resched_rcu_lock(void)
> {
> 	if (need_resched()) {
> 		rcu_read_unlock();
> 		cond_resched();
> 		rcu_read_lock();
> 	}
> }

	Thanks, looks like a good idea to me, I guess
its place is include/linux/sched.h. Simon, can you prepare
2 patches instead, one for cond_resched_rcu_lock and second
for ipvs?

Regards

--
Julian Anastasov <ja@....bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html