netdev - Re: getting VF link info seems to be broken in 3.9-rc8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 13:20:24 -0700
From:	Alexander Duyck <alexander.h.duyck@...el.com>
To:	David Miller <davem@...emloft.net>
CC:	mitch.a.williams@...el.com, ogerlitz@...lanox.com,
	gregory.v.rose@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, ronye@...lanox.com, shemminger@...tta.com
Subject: Re: getting VF link info seems to be broken in 3.9-rc8

On 04/25/2013 12:24 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@...el.com>
> Date: Thu, 25 Apr 2013 11:29:04 -0700
>
>> I did a bit of digging and it looks like the issue is that the
>> ext_filter_mask is not being found in the message received in
>> rtnl_dump_ifinfo.  I'm still trying to figure out why the kernel isn't
>> finding the flag when it was finding it previously, but I'm not much of
>> a netlink expert.
> I wonder if this has something to do with this commit:
>
> ====================
> From 88c5b5ce5cb57af6ca2a7cf4d5715fa320448ff9 Mon Sep 17 00:00:00 2001
> From: Michael Riesch <michael.riesch@...cron.at>
> Date: Mon, 8 Apr 2013 05:45:26 +0000
> Subject: [PATCH] rtnetlink: Call nlmsg_parse() with correct header length
>
> Signed-off-by: Michael Riesch <michael.riesch@...cron.at>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Jiri Benc <jbenc@...hat.com>
> Cc: "Theodore Ts'o" <tytso@....edu>
> Cc: linux-kernel@...r.kernel.org
> Acked-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/core/rtnetlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index b65441d..23854b5 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1072,7 +1072,7 @@ static int rtnl_dump_ifinfo(struct sk_buff *skb, struct netlink_callback *cb)
>  	rcu_read_lock();
>  	cb->seq = net->dev_base_seq;
>  
> -	if (nlmsg_parse(cb->nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX,
> +	if (nlmsg_parse(cb->nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX,
>  			ifla_policy) >= 0) {
>  
>  		if (tb[IFLA_EXT_MASK])
> @@ -1922,7 +1922,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct nlmsghdr *nlh)
>  	u32 ext_filter_mask = 0;
>  	u16 min_ifinfo_dump_size = 0;
>  
> -	if (nlmsg_parse(nlh, sizeof(struct rtgenmsg), tb, IFLA_MAX,
> +	if (nlmsg_parse(nlh, sizeof(struct ifinfomsg), tb, IFLA_MAX,
>  			ifla_policy) >= 0) {
>  		if (tb[IFLA_EXT_MASK])
>  			ext_filter_mask = nla_get_u32(tb[IFLA_EXT_MASK]);

I thought that as well.  I tried reverting it and the issue is still there.

However, I do think this may be part of the issue since I added a printk
to dump nlmsg_attrlen before going into the nlmsg_parse and with
ifinfomsg the attrlen is -12, with rtgenmsg it is 0.

Thanks,

Alex
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html