netdev - Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Apr 2013 23:11:05 +0000
From:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Sony Chacko <sony.chacko@...gic.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>,
	Himanshu Madhani <himanshu.madhani@...gic.com>
Subject: Re: [PATCH net-next 5/7] qlcnic: Rename the IRQ description.



On 4/24/13 5:05 PM, "Ben Hutchings" <bhutchings@...arflare.com> wrote:

>On Wed, 2013-04-24 at 18:42 -0400, Jitendra Kalsaria wrote:
>> From: Himanshu Madhani <himanshu.madhani@...gic.com>
>> 
>> Here's what modified vectors will look like
>> in the /proc/interrupts
>> 
>>         MSIx             	INTx
>> -----------------------------------------
>> 83xx    qlcnic[MB]
>> 	qlcnic-ethX[Rx0]
>> 	qlcnic-ethX[Rx1]
>> 	..
>> 	qlcnic-ethX[RxN]
>> 	qlcnic-ethx[Tx0]        qlcnic[MB+Tx0+Rx0]
>> 
>> 82xx    qlcnic-ethX[Rx0]
>> 	qlcnic-ethX[Rx1]
>> 	..
>> 	qlcnic-ethX[Tx0+RxN]    qlcnic-ethX[Tx0+Rx0]
>[...]
>
>Many other multiqueue drivers (including your own qlge) use these
>formats for IRQ handler names:

Thanks for the review. We will change the format in a future submission
according to your suggestion and similar to what other multiqueue drivers
are using.
>
>RX queue:   <device>-rx-<index>
>TX queue:   <device>-tx-<index>
>Queue pair: <device>-<index>

We will like to add the qlcnic prefix to the above format, as it makes it
easier for an end user to identify which driver these entries belongs to,
without having to run addition command.
This is how the format will look like:

       MSIx                    INTx
               -----------------------------------------
83xx   qlcnic-MB
       qlcnic-ethX-rx-0
       qlcnic-ethX-rx-1
       ..
       qlcnic-ethX-rx-N
       qlcnic-ethx-tx-0        qlcnic-MB-tx-0-rx-0
 
82xx   qlcnic-ethX-rx-0
       qlcnic-ethX-rx-1
       ..
       qlcnic-ethX-tx-0-rx-N   qlcnic-ethX-tx-0-rx-0

Thanks,

   Jiten
>
>Please use similar formats.
>
>Ben.
>
>-- 
>Ben Hutchings, Staff Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>
>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html