netdev - Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 17:32:02 +0800
From:	Frank Li <lznuaa@...il.com>
To:	Lucas Stach <l.stach@...gutronix.de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Fabio Estevam <festevam@...il.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable call"

2013/4/26 Lucas Stach <l.stach@...gutronix.de>:
> This reverts commit 3f104c38259dcb3e5443c246f0805bc04d887cc3.
>
> In preparaton to revert the other NAPI related changes.
>
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>

David:

Please hold apply this patch for some days.
Let me found a good way to fix the issue that lucas met.

This patch may cause spin_lock dead lock when using 1588 ptp.

best regards
Frank Li

> ---
>  drivers/net/ethernet/freescale/fec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
> index 73195f6..afb52eb 100644
> --- a/drivers/net/ethernet/freescale/fec.c
> +++ b/drivers/net/ethernet/freescale/fec.c
> @@ -1490,7 +1490,6 @@ fec_enet_close(struct net_device *ndev)
>         struct fec_enet_private *fep = netdev_priv(ndev);
>
>         /* Don't know what to do yet. */
> -       napi_disable(&fep->napi);
>         fep->opened = 0;
>         netif_stop_queue(ndev);
>         fec_stop(ndev);
> --
> 1.8.2.rc2
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html