netdev - Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw irq enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 14:03:24 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	davem@...emloft.net
CC:	Mugunthan V N <mugunthanvnm@...com>, netdev@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [net-next PATCH 1/1] drivers: net: cpsw: fix kernel warn on cpsw
 irq enable

On 04/26/2013 01:30 PM, Mugunthan V N wrote:
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 4e2d224..59c4391 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -1633,7 +1633,6 @@ static int cpsw_probe_dual_emac(struct platform_device *pdev,
>  		priv_sl2->irqs_table[i] = priv->irqs_table[i];
>  		priv_sl2->num_irqs = priv->num_irqs;
>  	}
> -	priv->irq_enabled = true;
>  	ndev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
>  
>  	ndev->netdev_ops = &cpsw_netdev_ops;
> @@ -1679,6 +1678,7 @@ static int cpsw_probe(struct platform_device *pdev)
>  	priv->msg_enable = netif_msg_init(debug_level, CPSW_DEBUG);
>  	priv->rx_packet_max = max(rx_packet_max, 128);
>  	priv->cpts = devm_kzalloc(&pdev->dev, sizeof(struct cpts), GFP_KERNEL);
> +	priv->irq_enabled = true;
>  	if (!ndev) {
>  		pr_err("error allocating cpts\n");
>  		goto clean_ndev_ret;


David, how did this happen? The patch I've sent

   http://www.spinics.net/lists/netdev/msg234240.html

adds this to the probe function, according to the net-next tree it was
added to cpsw_probe_dual_emac(). The context is similar but not exact
the same.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html