netdev - Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Apr 2013 15:44:15 +0200
From:	Robert Schwebel <r.schwebel@...gutronix.de>
To:	Frank Li <lznuaa@...il.com>
Cc:	Lucas Stach <l.stach@...gutronix.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Fabio Estevam <festevam@...il.com>,
	Shawn Guo <shawn.guo@...aro.org>
Subject: Re: [PATCH resend 1/3] Revert "net: fec: fix missing napi_disable
 call"

Frank,

On Fri, Apr 26, 2013 at 05:32:02PM +0800, Frank Li wrote:
> 2013/4/26 Lucas Stach <l.stach@...gutronix.de>:
> > This reverts commit 3f104c38259dcb3e5443c246f0805bc04d887cc3.
> >
> > In preparaton to revert the other NAPI related changes.
> >
> > Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
>
> David:
>
> Please hold apply this patch for some days.
> Let me found a good way to fix the issue that lucas met.
>
> This patch may cause spin_lock dead lock when using 1588 ptp.

Seriously - it's friday, and 3.9 is expected to come out this weekend.
You broke the driver in mainline with your patches, and the current
state is that it isn't fixable before the release.

So in order not to break the FEC in 3.9-final, please let's go with the
reverts for now; if 1588 PTP is broken, it was broken in 3.8 as well,
correct? After the release, there will be a lot of time to make proper
patches that fix the issues.

rsc
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html