netdev - Re: [Patch net-next 1/3] bridge: use the bridge IP addr as source addr of querier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Apr 2013 16:17:38 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Herbert Xu <herbert@...dor.hengli.com.au>
Cc:	netdev@...r.kernel.org,
	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Adam Baker <linux@...er-net.org.uk>
Subject: Re: [Patch net-next 1/3] bridge: use the bridge IP addr as source
 addr of querier

On Mon, 2013-04-29 at 15:43 +0800, Herbert Xu wrote:
> On Mon, Apr 29, 2013 at 03:26:30PM +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@...hat.com>
> > 
> > Quote from Adam:
> > "If it is believed that the use of 0.0.0.0
> > as the IP address is what is causing strange behaviour on other devices
> > then is there a good reason that a bridge rather than a router shouldn't
> > be the active querier? If not then using the bridge IP address and
> > having the querier enabled by default may be a reasonable solution
> > (provided that our querier obeys the election rules and shuts up if it
> > sees a query from a lower IP address that isn't 0.0.0.0). Just because a
> > device is the elected querier for IGMP doesn't appear to mean it is
> > required to perform any other routing functions."
> 
> I don't think we should make this the default.  Having it as an
> option though is fine with me.  We may also want to allow the user
> to explicitly set an IP address.

Good point. I think we should at least make it a boolen option, I am not
sure if allowing users to explicitly set it is overkill.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html