netdev - Re: [PATCH net-next v3] ipv6: Kill ipv6 dependency of icmpv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Apr 2013 10:44:45 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Cong Wang <xiyou.wangcong@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] ipv6: Kill ipv6 dependency of icmpv6_send().

On Sun, Apr 28, 2013 at 6:46 PM, Cong Wang <xiyou.wangcong@...il.com> wrote:
> On Thu, 25 Apr 2013 at 21:08 GMT, Pravin B Shelar <pshelar@...ira.com> wrote:
>> diff --git a/net/ipv6/ip6_icmp.c b/net/ipv6/ip6_icmp.c
>> new file mode 100644
>> index 0000000..4578e23
>> --- /dev/null
>> +++ b/net/ipv6/ip6_icmp.c
>> @@ -0,0 +1,47 @@
>> +#include <linux/export.h>
>> +#include <linux/icmpv6.h>
>> +#include <linux/mutex.h>
>> +#include <linux/netdevice.h>
>> +#include <linux/spinlock.h>
>> +
>> +#include <net/ipv6.h>
>> +
>> +#if IS_ENABLED(CONFIG_IPV6)
>> +
>
> I don't think we need #if IS_ENABLED(CONFIG_IPV6) inside
> net/ipv6/ip6_icmp.c.
>
This file is statically linked to kernel, So it needs this check to
avoid compilation errors.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html