netdev - Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg in rtnl_wilddump_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 May 2013 17:12:55 +0300
From:	Or Gerlitz <ogerlitz@...lanox.com>
To:	Alexander Duyck <alexander.h.duyck@...el.com>
CC:	<shemminger@...tta.com>, <netdev@...r.kernel.org>,
	<jeffrey.t.kirsher@...el.com>
Subject: Re: [IPROUTE PATCH] libnetlink: Use ifinfomsg instead of rtgenmsg
 in rtnl_wilddump_req_filter

On 26/04/2013 01:07, Alexander Duyck wrote:
> This change corrects a kernel incompatibility that was resulting in the
> ext_filter_mask not being correctly discovered by the kernel as it is buried
> somewhere in the ifinfomsg.

working well,  thanks for fixing this up Alex.

Or.

>
> Reported-by: Or Gerlitz <ogerlitz@...lanox.com>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> ---
>   lib/libnetlink.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> index 04201cd..b17e1aa 100644
> --- a/lib/libnetlink.c
> +++ b/lib/libnetlink.c
> @@ -99,7 +99,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
>   {
>   	struct {
>   		struct nlmsghdr nlh;
> -		struct rtgenmsg g;
> +		struct ifinfomsg ifm;
>   		/* attribute has to be NLMSG aligned */
>   		struct rtattr ext_req __attribute__ ((aligned(NLMSG_ALIGNTO)));
>   		__u32 ext_filter_mask;
> @@ -111,7 +111,7 @@ int rtnl_wilddump_req_filter(struct rtnl_handle *rth, int family, int type,
>   	req.nlh.nlmsg_flags = NLM_F_DUMP|NLM_F_REQUEST;
>   	req.nlh.nlmsg_pid = 0;
>   	req.nlh.nlmsg_seq = rth->dump = ++rth->seq;
> -	req.g.rtgen_family = family;
> +	req.ifm.ifi_family = family;
>   
>   	req.ext_req.rta_type = IFLA_EXT_MASK;
>   	req.ext_req.rta_len = RTA_LENGTH(sizeof(__u32));
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html