netdev - Re: [PATCH] S390: Fix libphy link failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 May 2013 11:00:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jdelvare@...e.de
Cc:	netdev@...r.kernel.org, heiko.carstens@...ibm.com
Subject: Re: [PATCH] S390: Fix libphy link failure

From: Jean Delvare <jdelvare@...e.de>
Date: Mon, 06 May 2013 16:53:39 +0200

> On S390 basic IRQ functions are provided by the PCI subsystem, so
> code which calls these cannot be built if PCI support was not
> selected.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> ---
> I know this isn't nice, but in the current state of S390 support
> this is all I can offer.

I really am tired of all of these special S390 dependencies.

You can't say this is a new problem, because we've been hitting this
issue repeatedly for more than a decade.  And I don't want to hear any
excuses, we've all already invested enough time into this to prove
that catering to S390's weird build limitations is a never ending
burdon for non-s390 people.

Really, our interfaces are abstract enough that every driver ought to
be buildable on every architecture.

It's time to put the burdon on your side, if you don't support some
IRQ interface or whatever, provide a stub that returns an error
rather than being that "special architecture" that everything else
has to specially cater for with ugly Kconfig dependencies.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html