netdev - Re: [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 May 2013 11:02:06 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	"'David S. Miller'" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH 09/36] net: ethernet: cadence: remove unnecessary platform_set_drvdata()

On 07/05/2013 06:23, Jingoo Han :
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>

Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

> ---
>   drivers/net/ethernet/cadence/at91_ether.c |    1 -
>   drivers/net/ethernet/cadence/macb.c       |    2 --
>   2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c
> index cc9a185..3f19571 100644
> --- a/drivers/net/ethernet/cadence/at91_ether.c
> +++ b/drivers/net/ethernet/cadence/at91_ether.c
> @@ -435,7 +435,6 @@ static int at91ether_remove(struct platform_device *pdev)
>   	unregister_netdev(dev);
>   	clk_disable(lp->pclk);
>   	free_netdev(dev);
> -	platform_set_drvdata(pdev, NULL);
>
>   	return 0;
>   }
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
> index 6be513d..6a7bf7d 100644
> --- a/drivers/net/ethernet/cadence/macb.c
> +++ b/drivers/net/ethernet/cadence/macb.c
> @@ -1635,7 +1635,6 @@ err_out_put_pclk:
>   err_out_free_dev:
>   	free_netdev(dev);
>   err_out:
> -	platform_set_drvdata(pdev, NULL);
>   	return err;
>   }
>
> @@ -1661,7 +1660,6 @@ static int __exit macb_remove(struct platform_device *pdev)
>   		clk_disable_unprepare(bp->pclk);
>   		clk_put(bp->pclk);
>   		free_netdev(dev);
> -		platform_set_drvdata(pdev, NULL);
>   	}
>
>   	return 0;
>


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html