netdev - Re: [PATCH] xen-netback: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 May 2013 11:00:48 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>
Subject: Re: [PATCH] xen-netback: remove dead code

On Mon, 2013-05-06 at 16:40 +0100, Wei Liu wrote:
> The array mmap_pages is never touched in the initialization function. This is
> remnant of mapping mechanism, which does exist upstream.
                                         ^not

Can you add a quick note about to the changelog about where this array
is now initialised and freed please, with that:

> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
Acked-by: Ian Campbell <ian.campbell@...rix.com>

Please resubmit when Dave opens net-next for new development.

Ian.

> ---
>  drivers/net/xen-netback/netback.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 37984e6..295a9c2 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1939,10 +1939,6 @@ static int __init netback_init(void)
>  failed_init:
>  	while (--group >= 0) {
>  		struct xen_netbk *netbk = &xen_netbk[group];
> -		for (i = 0; i < MAX_PENDING_REQS; i++) {
> -			if (netbk->mmap_pages[i])
> -				__free_page(netbk->mmap_pages[i]);
> -		}
>  		del_timer(&netbk->net_timer);
>  		kthread_stop(netbk->task);
>  	}


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html