netdev - Re: [PATCH] net/802/mrp: fix lockdep splat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 May 2013 12:41:07 -0400
From:	"Ward, David - 0663 - MITLL" <david.ward@...mit.edu>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Denys Fedoryshchenko <denys@...p.net.lb>,
	David Miller <davem@...emloft.net>,
	"amwang@...hat.com" <amwang@...hat.com>,
	"hayeswang@...ltek.com" <hayeswang@...ltek.com>,
	"romieu@...zoreil.com" <romieu@...zoreil.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] net/802/mrp: fix lockdep splat

On 05/15/2013 12:34 PM, Ward, David - 0663 - MITLL wrote:
> On 05/15/2013 11:22 AM, Eric Dumazet wrote:
>> Re: [PATCH] net/802/mrp: fix lockdep splat
>>
>> On Wed, 2013-05-15 at 17:50 +0300, Denys Fedoryshchenko wrote:
>> > On 2013-05-14 22:40, Eric Dumazet wrote:
>> > >
>> > > I definitely could trigger the bug easily without my patch :
>> >
>> >
>> > >
>> > > And with the patch, there is no lockdep splat anymore.
>> > >
>> > > Tested-by: Eric Dumazet <edumazet@...gle.com>
>> >
>> > Yes, it seems after depclean i cannot reproduce anymore this bug. My
>> > bad, seems i should recompile kernel completely next time.
>> >
>>
>> Thanks for testing again, I was quite mystified by your original
>> results ;)
>>
>
> FYI - I believe GARP (net/802/garp.c) needs the same fix. Thechange 
> that introduced this issue was originally copied from there.
>
> David
>

My bad... I copied the patch from GARP to MRP wrong... that's what 
created this problem in the first place.  Sorry.

David


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4571 bytes)