netdev - Re: [PATCH] vxlan: Update vxlan fdb 'used' field after each usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 15:22:44 -0700
From:	Sridhar Samudrala <sri@...ibm.com>
To:	David Miller <davem@...emloft.net>
Cc:	stephen@...workplumber.org, dlstevens@...ibm.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] vxlan: Update vxlan fdb 'used' field after each usage.

On Thu, 2013-05-16 at 15:00 -0700, David Miller wrote:
> From: Sridhar Samudrala <sri@...ibm.com>
> Date: Thu, 16 May 2013 10:05:43 -0700
> 
> > Fix some instances where vxlan fdb 'used' field is not updated after the entry 
> > is used.
> > 
> > Signed-off-by: Sridhar Samudrala <sri@...ibm.com>
> 
> Please just put the ->used update into vxlan_find_mac().

I thought of doing it that way, but i found that there is a call
to vxlan_find_mac() in vxlan_fdb_create() where the fdb entry
gets updated, but it not really used.

Also in other cases, the fdb entry may not be used even if
vxlan_find_mac() returns an entry because of other conditions.

I guess it depends on how we define the 'used' field.

Thanks
Sridhar

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html