netdev - Re: [PATCH] r8169: fix offloaded tx checksum for small packets.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 May 2013 02:59:34 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Hayes Wang <hayeswang@...ltek.com>,
	Stefan Bader <stefan.bader@...onical.com>,
	Holger Hoffstätte 
	<holger.hoffstaette@...glemail.com>
Subject: Re: [PATCH] r8169: fix offloaded tx checksum for small packets.

Hello.

On 05/17/2013 02:38 AM, Francois Romieu wrote:

> 8168evl offloaded checksums are wrong since
> e5195c1f31f399289347e043d6abf3ffa80f0005

     Please, also specify that commit's summary line in parens.

> pads small packets to
> 60 bytes (without ethernet checksum). Observed UDP checksums are
> typically wrong by the count of added bytes.
>
> It isn't worth compensating. Let's checksum by hand, then pad.
>
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Hayes Wang <hayeswang@...ltek.com>
> Tested-by: Holger Hoffstätte <holger.hoffstaette@...glemail.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html