netdev - Re: [PATCH] bonding: allow TSO being set on bonding master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 10:59:25 +0200
From:	Michał Mirosław <mirqus@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Jay Vosburgh <fubar@...ibm.com>,
	Maciej Żenczykowski <maze@...gle.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Tom Herbert <therbert@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH] bonding: allow TSO being set on bonding master

2013/5/16 Eric Dumazet <eric.dumazet@...il.com>:
> On Thu, 2013-05-16 at 07:45 +0200, Michał Mirosław wrote:
>
>> This should enable GSO if at least one slave has it on. What features
>> (tx-tcp*) the slaves have?
>
> Both slaves have tso off, gso on.
>
> (Let's say for some tricky hardware bug on the NIC)
>
> We want to not do tso on the NIC, but do the GSO segmentation right
> before NIC.
>
> It brings about 30% improvement.

Then your patch is the way to go.

BTW, the fix_features callbacks of bridge, team and bonding are so
similar it calls for some refactoring. What they want also seems very
close.

Best Regards,
Michał Mirosław
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html