netdev - Re: [PATCH] sfc: Enable accelerated RFS on vlans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 May 2013 12:45:09 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>
Subject: Re: [PATCH] sfc: Enable accelerated RFS on vlans

On Thu, May 16, 2013 at 11:38 AM, Ben Hutchings
<bhutchings@...arflare.com> wrote:
> On Fri, 2013-05-10 at 16:51 -0700, Andy Lutomirski wrote:
>> As far as I know, the hardware doesn't support matching on both IP
>> fields and vlan tag, but it can at least match on the vlan tag.
>>
>> Signed-off-by: Andy Lutomirski <luto@...capital.net>
>> ---
>>
>> Tested on the OpenOnload version of the driver, but the patch is the same
>> other than some offset.
>
> This looks correct, but I'll have to actually test it.  So I'll queue
> this up and re-submit along with other sfc patches later on, OK?

Fine with me.  (Is there a combined vlan + IP filter that I don't know about?)

When you resubmit it, it might be worth fixing the blatant typo (vlan
tag -> IP fields) in the description, though :/

>
>> With this patch, accelerated RFS works for me.  (Oddly, some packets end
>> up on otherwise idle cores, even when those cores have weight zero in
>> ethtool --set-rxfh-indir; I'm not sure what's going on there.)
>
> Some packets, or some interrupts?  TX completions and wake-up events (if
> you use user-level networking) are of course not affected by the RX flow
> hash indirection table..

It's TX completions -- I figured that out after I sent this patch.

>
> You might find it useful to dump the complete RX filter table by running
> 'ethtool -d'.  ('ethtool -n' only shows the manually controlled
> filters.)

Thanks -- that's useful.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html