netdev - Re: [PATCH v3] Bluetooth: hidp: using strlcpy instead of strncpy, also beautify code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 May 2013 15:04:35 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Jiri Kosina <jkosina@...e.cz>
CC:	Gustavo Padovan <gustavo@...ovan.org>,
	David Herrmann <dh.herrmann@...il.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Johan Hedberg <johan.hedberg@...il.com>,
	David Miller <davem@...emloft.net>,
	andrei.emeltchenko@...el.com,
	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v3] Bluetooth: hidp: using strlcpy instead of strncpy,
 also beautify code.

Hello Maintainers:

Please help check this patch when you have time, thanks.

It is "Reviewed-by: David Herrmann <dh.herrmann@...il.com>"

And also is "Acked-by: Jiri Kosina <jkosina@...e.cz>"

If need me do any additional things, please tell me.


Thanks.

On 05/13/2013 10:07 AM, Chen Gang wrote:
> 
> For NUL terminated string, need always let it ended by zero.
> 
> Since have already called memcpy() to initialize 'ci', so need not
> redundant initialization.
> 
> Better use ''if(session->hid) {} else if(session->input) {}"" instead
> of ''if(session->hid) {}; if(session->input) {};''
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  net/bluetooth/hidp/core.c |   14 ++++----------
>  1 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
> index 940f5ac..f13a8da 100644
> --- a/net/bluetooth/hidp/core.c
> +++ b/net/bluetooth/hidp/core.c
> @@ -76,25 +76,19 @@ static void hidp_copy_session(struct hidp_session *session, struct hidp_conninfo
>  	ci->flags = session->flags;
>  	ci->state = BT_CONNECTED;
>  
> -	ci->vendor  = 0x0000;
> -	ci->product = 0x0000;
> -	ci->version = 0x0000;
> -
>  	if (session->input) {
>  		ci->vendor  = session->input->id.vendor;
>  		ci->product = session->input->id.product;
>  		ci->version = session->input->id.version;
>  		if (session->input->name)
> -			strncpy(ci->name, session->input->name, 128);
> +			strlcpy(ci->name, session->input->name, 128);
>  		else
> -			strncpy(ci->name, "HID Boot Device", 128);
> -	}
> -
> -	if (session->hid) {
> +			strlcpy(ci->name, "HID Boot Device", 128);
> +	} else if (session->hid) {
>  		ci->vendor  = session->hid->vendor;
>  		ci->product = session->hid->product;
>  		ci->version = session->hid->version;
> -		strncpy(ci->name, session->hid->name, 128);
> +		strlcpy(ci->name, session->hid->name, 128);
>  	}
>  }
>  
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html