netdev - Re: [PATCH net-next] net: small skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 May 2013 10:20:04 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: small skb_segment() cleanup

On Fri, May 17, 2013 at 10:13 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>


> @@ -2817,7 +2817,6 @@ struct sk_buff *skb_segment(struct sk_buff *skb, netdev_features_t features)
>
>                         nskb->truesize += skb_end_offset(nskb) - hsize;
>                         skb_release_head_state(nskb);
> -                       __skb_push(nskb, doffset);

is __skb_push equivalent to __skb_put?

Harvey

>                 } else {
>                         nskb = __alloc_skb(hsize + doffset + headroom,
>                                            GFP_ATOMIC, skb_alloc_rx_flag(skb),
> @@ -2827,8 +2826,8 @@ struct sk_buff *skb_segment(struct sk_buff *skb, netdev_features_t features)
>                                 goto err;
>
>                         skb_reserve(nskb, headroom);
> -                       __skb_put(nskb, doffset);
>                 }
> +               __skb_put(nskb, doffset);
>
>                 if (segs)
>                         tail->next = nskb;
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html