lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 May 2013 17:02:50 +0100 From: Ben Hutchings <bhutchings@...arflare.com> To: Eliezer Tamir <eliezer.tamir@...ux.intel.com> CC: Or Gerlitz <or.gerlitz@...il.com>, Greg Rose <gregory.v.rose@...el.com>, Yinghai Lu <yinghai@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, "Gu Zheng" <guz.fnst@...fujitsu.com>, <linux-pci@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Alexander Duyck <alexander.h.duyck@...el.com>, Yan Burman <yanb@...lanox.com>, Sathya Perla <Sathya.Perla@...lex.com>, <netdev@...r.kernel.org> Subject: Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's On Mon, 2013-05-20 at 15:58 +0300, Eliezer Tamir wrote: > On 20/05/2013 15:28, Or Gerlitz wrote: > > On Wed, May 15, 2013 at 7:12 PM, Greg Rose <gregory.v.rose@...el.com> wrote: > > > > > >> I'm really not a fan of this. Seems to me the tail is wagging the dog > >> here. Fix the driver to work without a PF driver being present. > > > > Greg, Alex, > > > > As I wrote over the V1 thread, currently we can't go and patch mlx4 to > > use the sysfs API nor defer the call from within our probe function to > > enable sriov since this requires some firmware change to allow > > enabling SRIOV after some resources are initialized/provisioned. > > Hence the patch suggested here or any other patch we can agree on > > which will make sure that VF probing is done only once the PF is ready > > is preferred, I think. > > > Maybe do the following: > 1. split the VF PCI IDs into a separate PCI_ID device table. > 2. have two pci_driver structs, one for all of the PF IDS and one with > the VF IDS. > 3. only register the first pci_driver struct from mlx4_init(). > 4. register the one for the VFs once your PFs are all up and ready. But hotplug. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists