netdev - Re: [PATCH net-next 0/2] Xen network: split event channels support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 May 2013 09:17:35 +0100
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Wei Liu <wei.liu2@...rix.com>
CC:	David Miller <davem@...emloft.net>, <xen-devel@...ts.xen.org>,
	<netdev@...r.kernel.org>, <konrad.wilk@...cle.com>
Subject: Re: [PATCH net-next 0/2] Xen network: split event channels support

On Tue, 2013-05-21 at 09:00 +0100, Wei Liu wrote:
> On Mon, May 20, 2013 at 11:27:52PM -0700, David Miller wrote:
> > 
> > If you use the same exact subject line in all of your patches in the
> > series, nobody reading the shortlog can tell what's different about
> > them.
> > 
> > You absolutely must resubmit this with more descriptive subject lines
> > which more accurately describe what each patch uniquely does.
> 
> I'm not sure I get what you mean. Their subject lines look alike, but
> not exactly the same.
> 
> So this patch set adds a new feature to Xen network device, which is
> called split event channels. The subject lines of two patches, one for
> frontend and one for backend, speak for themselves.

This is true, but I wonder if peoples eyes tend to skip over the initial
prefix.

> No matter how I change the subject lines, they will probably still look
> alike except for the leading "xen-netfront / xen-netback".  I can squash
> them into one changeset if that better suits your workflow, but it is
> better to leave them separate IMHO so that we can test them separately.
>
> Advice welcomed.

How about "xen-netback: Split event channel support for Xen Backend
driver" and the equivalent for frontend? 

I'd prefer to keep it as two changesets if possible.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html