netdev - Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 May 2013 14:29:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	eric.dumazet@...il.com, pablo@...filter.org,
	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	therbert@...gle.com, kaber@...sh.net
Subject: Re: [PATCH v2 nf-next] netfilter: conntrack: remove the central
 spinlock

From: Joe Perches <joe@...ches.com>
Date: Wed, 22 May 2013 14:12:51 -0700

> @@ -528,7 +528,7 @@ struct netdev_queue {
>   * write mostly part
>   */
>  	spinlock_t		_xmit_lock ____cacheline_aligned_in_smp;
> -	int			xmit_lock_owner;
> +	u16			xmit_lock_owner;
>  	/*
>  	 * please use this field instead of dev->trans_start
>  	 */
> @@ -2453,7 +2453,7 @@ static inline void __netif_tx_unlock_bh(struct netdev_queue *txq)
>  
>  static inline void txq_trans_update(struct netdev_queue *txq)
>  {
> -	if (txq->xmit_lock_owner != -1)
> +	if (txq->xmit_lock_owner != (u16)-1)
>  		txq->trans_start = jiffies;
>  }

Then technically this is an s16, don't use casts to pretend that it
isn't.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html