netdev - Re: [PATCH v2 net-next] tcp: remove one indentation level in tcp_rcv_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 May 2013 10:12:57 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>
Subject: Re: [PATCH v2 net-next] tcp: remove one indentation level in
 tcp_rcv_state_process()

On Thu, 2013-05-23 at 10:09 -0700, Joe Perches wrote:
> On Thu, 2013-05-23 at 08:55 -0700, Eric Dumazet wrote:
> > Remove one level of indentation 'introduced' in commit
> > c3ae62af8e75 (tcp: should drop incoming frames without ACK flag set)
> []
> > diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> []
> > -				if (sk->sk_socket)
> > -					sk_wake_async(sk,
> > -						      SOCK_WAKE_IO, POLL_OUT);
> []
> > +			if (sk->sk_socket)
> > +				sk_wake_async(sk,
> > +					      SOCK_WAKE_IO, POLL_OUT);
> 
> It'd also be nice to reflow the lines to 80 cols.
> 
> 				sk_wake_async(sk, SOCK_WAKE_IO, POLL_OUT);
> 

ok will do.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html