netdev - RE: [PATCH] be2net: bug fix on returning an invalid nic descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 May 2013 04:32:40 +0000
From:	"Perla, Sathya" <Sathya.Perla@...lex.Com>
To:	Wei Yang <weiyang@...ux.vnet.ibm.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH] be2net: bug fix on returning an invalid nic descriptor

> -----Original Message-----
> From: Wei Yang [mailto:weiyang@...ux.vnet.ibm.com]
> 
> In function be_get_nic_desc(), it will go through the descriptor array
> returned from f/w. By comparing the desc_type field, it determines whether
> there is a nic descriptor in the array or not. In the case of no nic descriptor,
> this function should return NULL.
> 
> The code may return an invalide descriptor, when there is no nic descriptor in
> the array and the desc_count is less than MAX_RESOURCE_DESC. In this
> case, even there is no nic descriptor, it will still return the lase descriptor
> since the i doesn't equal to MAX_RESOURCE_DESC.
> 
> This patch fix this issue by returning the descriptor when find it and return
> NULL for other cases.
> 
> Signed-off-by: Wei Yang <weiyang@...ux.vnet.ibm.com>
> Reviewed-by: Gavin Shan <shangw@...ux.vnet.ibm.com>
> Reviewed-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>

Acked-by: Sathya Perla <sathya.perla@...lex.com>

Thanks for the fix.
-Sathya
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html