netdev - Re: Some netfilter compile errors when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 May 2013 14:33:39 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Cong Wang <amwang@...hat.com>
Cc:	netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
	Patrick McHardy <kaber@...sh.net>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: Some netfilter compile errors when CONFIG_IPV6=m

On Tue, May 14, 2013 at 10:45:52AM +0800, Cong Wang wrote:
> Hi, all
> 
> I got the following compile errors when I compile IPv6 as a module and
> most of the rest are built into core kernel. David Miller insists we
> should fix this kind of error and not by adding Kconfig tricks.
> 
> net/built-in.o: In function `nf_tproxy_get_sock_v6':
> /home/wangcong/linux/include/net/netfilter/nf_tproxy_core.h:177:
> undefined reference to `udp6_lib_lookup'
> /home/wangcong/linux/include/net/netfilter/nf_tproxy_core.h:177:
> undefined reference to `udp6_lib_lookup'
> net/built-in.o: In function `tproxy_tg_init':
> /home/wangcong/linux/net/netfilter/xt_TPROXY.c:415: undefined reference
> to `nf_defrag_ipv6_enable'
> net/built-in.o: In function `socket_mt_init':
> /home/wangcong/linux/net/netfilter/xt_socket.c:366: undefined reference
> to `nf_defrag_ipv6_enable'

Looking at your incomplete .config, I don't see how you set xt_TPROXY
and xt_socket but I bet they are =y.

For the udp6_lib_lookup dependency, you can use the ipv6 hooks added
here:

commit 2a7851bffb008ff4882eee673da74718997b4265
Author: Florian Westphal <fw@...len.de>
Date:   Fri May 17 03:56:10 2013 +0000

    netfilter: add nf_ipv6_ops hook to fix xt_addrtype with IPv6

Already in the nf tree, to resolve it. It would be fairly easy to make
a patch for it.

For the nf_defrag_ipv6_enable, as I already mentioned, that's an
artificial function to enforce the dependency between those two
modules. We can add runtime checks in socket and TPROXY to skip
further processing is nf_defrag_ipv6 is not loaded. But that's a
problem because users will assume that their socket/TPROXY rule got
loaded but it will not actually work since defrag is not loaded.  I
think that really needs some Kconfig tricks for that specific case.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html