netdev - Re: [PATCH 7/7] tulip: remove redundant D0 power state set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 May 2013 08:31:38 -0700
From:	Grant Grundler <grantgrundler@...il.com>
To:	Yijing Wang <wangyijing@...wei.com>
Cc:	Grant Grundler <grundler@...isc-linux.org>,
	Hanjun Guo <guohanjun@...wei.com>,
	Jiang Liu <liuj97@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	NetDev <netdev@...r.kernel.org>
Subject: Re: [PATCH 7/7] tulip: remove redundant D0 power state set

On Thu, May 30, 2013 at 3:27 AM, Yijing Wang <wangyijing@...wei.com> wrote:
> Pci_enable_device() will set device power state to D0,
> so it's no need to do it again in tulip_init_one().
>
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>

Ack-by: Grant Grundler <grundler@...isc-linux.org>

thanks!
grant

> ---
>  drivers/net/ethernet/dec/tulip/tulip_core.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c
> index 1e9443d..c94152f 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip_core.c
> +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c
> @@ -1410,12 +1410,6 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
>                 return i;
>         }
>
> -       /* The chip will fail to enter a low-power state later unless
> -        * first explicitly commanded into D0 */
> -       if (pci_set_power_state(pdev, PCI_D0)) {
> -               pr_notice("Failed to set power state to D0\n");
> -       }
> -
>         irq = pdev->irq;
>
>         /* alloc_etherdev ensures aligned and zeroed private structures */
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html