netdev - Re: cw1200 "sbus" conflicts with SPARC "sbus"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 May 2013 08:05:54 -0400
From:	Solomon Peachy <pizza@...ftnet.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	"John W. Linville" <linville@...driver.com>,
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: cw1200 "sbus" conflicts with SPARC "sbus"

On Fri, May 31, 2013 at 11:31:05AM +0200, Geert Uytterhoeven wrote:
> 
> sparc64/allmodconfig:
> 
> drivers/net/wireless/cw1200/hwio.c:51:21: error: macro "sbus_memcpy_fromio" passed 4 arguments, but takes just 3
> drivers/net/wireless/cw1200/hwio.c:66:19: error: macro "sbus_memcpy_toio" passed 4 arguments, but takes just 3
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/8846508/
> 
> At first I thought it was a bad/old implementation of a real SPARC sbus
> driver.  but it seems the two sbusses are completely unrelated.

Yikes. 

Would it be sufficient to just rename that pair of macros, or should I 
go and rename entire cw1200's "bus" subsystem?

Either way, I'll add this to the to-do list for the weekend.

 - Solomon
-- 
Solomon Peachy        		       pizza at shaftnet dot org	 
Delray Beach, FL                          ^^ (mail/jabber) ^^
Quidquid latine dictum sit, altum viditur.

Content of type "application/pgp-signature" skipped