netdev - Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 01 Jun 2013 20:06:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	lorenzo@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com,
	yoshfuji@...ux-ipv6.org, segoon@...nwall.com
Subject: Re: [PATCH v4 1/4] Clean up indentation in net/ipv6/transp_v6.h

On Sat, 2013-06-01 at 19:58 -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Fri, 31 May 2013 18:25:40 -0700
> 
> > externs aren't useful here and I suggest prototypes like
> > int ipv6_exthdrs_init(void);
> 
> But this is the format used by the entire header file, all functions
> are declared extern.
> 
> It is not reasonable to ask him to change this.  It's a seperate
> cleanup, and that's assuming we actually agree to remove the externs.
> I honestly see no reason to, they are harmless, and given that it's
> just pure churn.

<shrug>

How is that churn different than the entire patch?

extern _isn't_ useful and the tabbed indentation is
different than most all includes.

1 tab or 2 isn't a big thing.

I think cleanup patches like this should strive for
consistency with whatever preferred style exists.

If a cleanup only patch is proffered, I think the
cleanup should be as complete as possible.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html