netdev - RE: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Jun 2013 13:26:29 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Chen Gang" <gang.chen@...anux.com>,
	"Andy Shevchenko" <andy.shevchenko@...il.com>,
	<edumazet@...gle.com>
Cc:	"Pravin Shelar" <pshelar@...ira.com>, <mgorman@...e.de>,
	"David Miller" <davem@...emloft.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, "netdev" <netdev@...r.kernel.org>,
	"Ben Hutchings" <bhutchings@...arflare.com>
Subject: RE: [PATCH v2] include/linux/skbuff.h: using '(u16) ~0U' instead of '~0U'

> +#define SKB_HEADER_UNSET_16	((unsigned short) ~0U)
> +

The _16 part isn't really correct, the type could be changed
and then it would be wrong.

I think I might have used SKB_HEADER_OFFSET.

	David