netdev - Re: xen-netback stable backports request (regression fixes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jun 2013 21:52:59 +0100
From:	Ian Campbell <ian.campbell@...rix.com>
To:	Greg KH <greg@...ah.com>
CC:	<stable@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
	xen-devel <xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>,
	Wei Liu <wei.liu2@...rix.com>
Subject: Re: xen-netback stable backports request (regression fixes)

On Wed, 2013-06-05 at 13:25 -0700, Greg KH wrote: 
> > For the first we thought that allocating a variable size array on the
> > stack was bad practice which could lead to a stack overflow. The default
> > is safe but can be overridden by a module parameter.
> > 
> > The other renames the module parameter which we thought was useful for
> > consistency between newer kernels and the stable branches.
> 
> So you are doing a user/kernel api change in a stable branch?  Heck, you
> did it in 3.10?  Why?  What did you just break by doing that?  I can't
> do that to users of the stable kernels, sorry, and you shouldn't be
> doing that to users of the 3.10 kernel either.  You should rename this
> back so people's working systems don't break when they upgrade their
> kernel.

The module parameter was introduce after 3.9 and then renamed before
v3.10-rc1 happened, the original name was never part of an -rc let alone
an actual release.

I hadn't considered the consequences of the introduction and renaming
getting backported to stable in separate stable releases, sorry.

I think in practise it is highly unlikely that anyone is using this
option but equally I'd rather change the name before people do to start
to use it.

If this is a problem for stable perhaps a patch to make it accept either
name would be useful? Seems to me like that is just deferring things a
bit further though.

> No worries, I've applied just the 9ecd1a75 patch.

Thanks,

Ian.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html