lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 5 Jun 2013 06:59:56 +0000 (UTC) From: Cong Wang <xiyou.wangcong@...il.com> To: netdev@...r.kernel.org Subject: Re: [PATCH net-next 02/10] vxlan: handle skb_clone failure On Wed, 05 Jun 2013 at 04:24 GMT, Stephen Hemminger <stephen@...workplumber.org> wrote: > skb1 = skb_clone(skb, GFP_ATOMIC); > - rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc); > - if (rc == NETDEV_TX_OK) > - rc = rc1; > + if (skb1) { > + rc1 = vxlan_xmit_one(skb1, dev, rdst, did_rsc); > + if (rc == NETDEV_TX_OK) > + rc = rc1; > + } If OOM, shouldn't we exit immediately instead of continue handle the next one? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists