[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 6 Jun 2013 16:09:33 -0400
From: Dave Jones <davej@...hat.com>
To: Jesse Larrew <jlarrew@...ux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>,
Rusty Russell <rusty@...tcorp.com.au>,
"David S. Miller" <davem@...emloft.net>,
Jason Wang <jasowang@...hat.com>,
Cong Wang <amwang@...hat.com>, Amos Kong <akong@...hat.com>,
virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, qemu-devel@...gnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-net: put virtio net header inline
with data
On Thu, Jun 06, 2013 at 02:59:44PM -0500, Jesse Larrew wrote:
> > pr_debug("%s: xmit %p %pM\n", vi->dev->name, skb, dest);
> > + if (vi->mergeable_rx_bufs)
> > + hdr_len = sizeof hdr->mhdr;
> > + else
> > + hdr_len = sizeof hdr->hdr;
>
> All conditionals need braces.
Documentation/CodingStyle disagrees:
"Do not unnecessarily use braces where a single statement will do."
Dave
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists