netdev - Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Jun 2013 13:00:52 +0200
From:	Matthias Schiffer <mschiffer@...verse-factory.net>
To:	David Miller <davem@...emloft.net>
CC:	xiyou.wangcong@...il.com, kuznet@....inr.ac.ru, jmorris@...ei.org,
	yoshfuji@...ux-ipv6.org, kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net/3.9] ipv6: ndisc: fix ndisc_send_redirect writing
 to the wrong skb

On 05/31/2013 10:42 AM, David Miller wrote:
> From: Cong Wang <xiyou.wangcong@...il.com>
> Date: Fri, 31 May 2013 11:23:11 +0800
> 
>> On Fri, May 31, 2013 at 9:27 AM, Matthias Schiffer
>> <mschiffer@...verse-factory.net> wrote:
>>> Since some refactoring in 5f5a011, ndisc_send_redirect called
>>> ndisc_fill_redirect_hdr_option on the wrong skb, leading to data corruption or
>>> in the worst case a panic when the skb_put failed.
>>>
>>> Signed-off-by: Matthias Schiffer <mschiffer@...verse-factory.net>
>>
>>
>> Good catch!
>>
>> Reviewed-by: Cong Wang <xiyou.wangcong@...il.com>
> 
> I've queued this up for -stable.
> 

I saw that this was marked as 'not applicable' in the patchwork - it
should still be applied to the net tree though. I hope my patch tag
'net/3.9' didn't cause any confusion, I meant net *and* 3.9.


Download attachment "signature.asc" of type "application/pgp-signature" (264 bytes)