netdev - Re: [PATCH net v2 01/03] vxlan: only migrate dynamic FDB entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Jun 2013 00:27:02 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net v2 01/03] vxlan: only migrate dynamic FDB entries

Hello.

On 06/11/2013 12:13 AM, Stephen Hemminger wrote:

> Only migrate dynamic forwarding table entries, don't modify
> static entries. If packet received from incorrect source IP address
> assume it is an imposter and drop it.

> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>

> ---
> Should go to -stable as well.

> --- a/drivers/net/vxlan.c	2013-06-06 08:27:07.499595174 -0700
> +++ b/drivers/net/vxlan.c	2013-06-06 09:38:54.291654035 -0700
> @@ -603,9 +603,10 @@ skip:
>
>   /* Watch incoming packets to learn mapping between Ethernet address
>    * and Tunnel endpoint.
> + * Return true if packet is bogus and should be droppped.
>    */
> -static void vxlan_snoop(struct net_device *dev,
> -			__be32 src_ip, const u8 *src_mac)
> +static bool vxlan_snoop(struct net_device *dev,
> +		       __be32 src_ip, const u8 *src_mac)

    Not clear why you changed the indentation of the second line...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html