netdev - Re: [PATCH net-next 1/2] net: remove NET_LL_RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Jun 2013 05:13:34 +0300
From:	Eliezer Tamir <eliezer.tamir@...ux.intel.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, jesse.brandeburg@...el.com,
	donald.c.skidmore@...el.com, e1000-devel@...ts.sourceforge.net,
	willemb@...gle.com, erdnetdev@...il.com, bhutchings@...arflare.com,
	andi@...stfloor.org, hpa@...or.com, eilong@...adcom.com,
	or.gerlitz@...il.com, amirv@...lanox.com, eliezer@...ir.org.il
Subject: Re: [PATCH net-next 1/2] net: remove NET_LL_RX_POLL config menue

On 13/06/2013 05:01, Stephen Hemminger wrote:
> On Wed, 12 Jun 2013 15:12:05 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
>
>> From: Eliezer Tamir <eliezer.tamir@...ux.intel.com>
>> Date: Tue, 11 Jun 2013 17:24:28 +0300
>>
>>>   	depends on X86_TSC
>>
>> Wait a second, I didn't notice this before.  There needs to be a better
>> way to test for the accuracy you need, or if the issue is lack of a proper
>> API for cycle counter reading, fix that rather than add ugly arch
>> specific dependencies to generic networking code.
>
> This should be sched_clock(), rather than direct TSC access.
> Also any code using TSC or sched_clock has to be carefully audited to deal with
> clocks running at different rates on different CPU's. Basically value is only
> meaning full on same CPU.

OK,

If we covert to sched_clock(), would adding a define such as 
HAVE_HIGH_PRECISION_CLOCK to architectures that have both a high 
precision clock and a 64 bit cycles_t be a good solution?

(if not any other suggestion?)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html