lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jun 2013 23:02:01 -0700 From: John Fastabend <john.fastabend@...il.com> To: "Michael S. Tsirkin" <mst@...hat.com> CC: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Roopa Prabhu <roprabhu@...co.com>, John Fastabend <john.r.fastabend@...el.com>, Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org Subject: Re: [PATCH net] macvlan: don't touch promisc without passthrough On 06/12/2013 06:56 AM, Sergei Shtylyov wrote: > Hello. > > On 12-06-2013 15:34, Michael S. Tsirkin wrote: > >> commit df8ef8f3aaa6692970a436204c4429210addb23a in linux 3.5 added a way > > Please also specify that commit's summary line in parens. > >> to control NOPROMISC macvlan flag through netlink. > >> However, with a non passthrough device we don't set promisc on open or >> clear it on stop, even if NOPROMISC is off. As a result: > >> If userspace clears NOPROMISC on open, then does not clear it on a >> netlink command, promisc counter is not decremented on stop and there >> will be no way to clear it once macvlan is detached. > >> If userspace does not clear NOPROMISC on open, then sets NOPROMISC on a >> netlink command, promisc counter will be decremented from 0 and overflow >> to fffffffff with no way to clear promisc afterwards. > >> To fix, simply ignore NOPROMISC flag in a netlink command for >> non-passthrough devices, same as we do at open/stop. > >> While at it - since we touch this code anyway - check >> dev_set_promiscuity return code and pass it to users (though an error >> here is unlikely). > >> Cc: "David S. Miller" <davem@...emloft.net> >> CC: Roopa Prabhu <roprabhu@...co.com> >> Cc: John Fastabend <john.r.fastabend@...el.com> >> Signed-off-by: Michael S. Tsirkin <mst@...hat.com> >> --- > >> Please review, and consider for 3.10 and -stable. > Other than those few nits looks good to me thanks! Reviewed-by: John Fastabend <john.r.fastabend@...el.com> -- John Fastabend Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists