netdev - RE: [RFC][PATCH net-next] cxgb4: Do not set net_device::dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Jun 2013 06:15:43 +0000
From:	Dimitrios Michailidis <dm@...lsio.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	netdev <netdev@...r.kernel.org>,
	"Narendra_K@...l.com" <Narendra_K@...l.com>
Subject: RE: [RFC][PATCH net-next] cxgb4: Do not set net_device::dev_id to
 VI index

Ben Hutchings wrote:
> 
> net_device::dev_id should not be used merely to indicate a VI index,
> as it affects the way the local part of IPv6 addresses is normally
> generated.
> 
> This field was intended for use where multiple devices may share a
> single assigned MAC address and need to have different IPv6 addresses.
> T4 VIs each have their own MAC address.
> 
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>

Acked-by: Dimitris Michailidis <dm@...lsio.com>

> ---
> Dimitris, I don't know whether my last statement ('VIs each have their
> own MAC address') is actually correct.  If not then the driver is quite
> right to set dev_id.

Ben, yes, VIs have individual MAC addresses.  Thanks for doing the patch.