lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 13 Jun 2013 02:25:24 -0700 (PDT) From: David Miller <davem@...emloft.net> To: florian@...nwrt.org Cc: netdev@...r.kernel.org, ralf@...ux-mips.org, blogic@...nwrt.org, linux-mips@...ux-mips.org, mbizon@...ebox.fr, jogo@...nwrt.org, cernekee@...il.com Subject: Re: [PATCH net-next] bcm63xx_enet: add support Broadcom BCM6345 Ethernet From: Florian Fainelli <florian@...nwrt.org> Date: Thu, 13 Jun 2013 09:58:34 +0100 > 2013/6/13 David Miller <davem@...emloft.net>: >> From: Florian Fainelli <florian@...nwrt.org> >> Date: Wed, 12 Jun 2013 20:53:05 +0100 >> >>> +#ifdef BCMCPU_RUNTIME_DETECT >> >> I want the MIPS folks to fix this brain damange. >> >> This runtime detect thing is just a big mess in a header file >> using hundreds of lines of CPP stuff to express what is fundamentally >> a simple (albeit sizable) Kconfig dependency. > > The codebase supporting the Broadcom BCM63xx SoC supports about 6-7 You don't need to explain it to me, I read the code and understand what it's trying to accomplish. I reject the implementation of it, only. > No, the ifdefs are kept in the arch/mips/bcm63xx portions of the code > specifically for that reason. The driver just needs to take into account a > new set of platform_data properties to deal with this. Fine, it's still terrible. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists