lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jun 2013 10:38:14 +0900 From: Fernando Luis Vazquez Cao <fernando_b1@....ntt.co.jp> To: David Miller <davem@...emloft.net> CC: bhutchings@...arflare.com, kaber@...sh.net, netdev@...r.kernel.org Subject: Re: [PATCH] vlan: restore ethtool ABI to control VLAN hardware acceleration On 2013年06月18日 09:10, David Miller wrote: > From: Ben Hutchings <bhutchings@...arflare.com> > Date: Mon, 17 Jun 2013 19:20:54 +0100 > >> On Mon, 2013-06-17 at 11:28 +0900, Fernando Luis Vázquez Cao wrote: >>> As part of the push to add 802.1ad server provider tagging support to the >>> kernel the VLAN features flags were renamed. Unfortunately the kernel name >>> for the VLAN hardware acceleration features that the kernel shows user space >>> was included in the rename, which broke ethtool (txvlan and rxvlan options >>> do not work). >> I expected something like that and said this was an ABI change, but >> apparently my objection wasn't sufficient. >> >>> This patch restores the original names, i.e. the original ABI. >>> If we wanted to make clear to users that we are refering to CTAGs we can >>> always change ethtool's short_name and long_name for these features (for >>> example something along the lines of txvlan -> txvlan-ctag, tx-vlan-offload -> >>> tx-vlan-ctag-offload). >>> >>> Cc: Patrick McHardy <kaber@...sh.net> >>> Cc: David S. Miller <davem@...emloft.net> >>> Cc: netdev@...r.kernel.org >>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@....ntt.co.jp> >> Reviewed-by: Ben Hutchings <bhutchings@...arflare.com> > Ok Ben you were indeed right :-) > > Applied, thanks. Could you get this to Linus before 3.10 is out? Thanks, Fernando -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists