netdev - Re: qlen check in tun.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Jun 2013 11:07:25 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Jerry Chu <hkchu@...gle.com>
Cc:	Jason Wang <jasowang@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: qlen check in tun.c

On Wed, Jun 19, 2013 at 12:39:34PM -0700, Jerry Chu wrote:
> Hi Jason,
> 
> On Tue, Jun 18, 2013 at 8:29 PM, Jason Wang <jasowang@...hat.com> wrote:
> > On 06/19/2013 10:31 AM, Jerry Chu wrote:
> >> In tun_net_xmit() the max qlen is computed as
> >> dev->tx_queue_len / tun->numqueues. For multi-queue configuration the
> >> latter may be way too small, forcing one to adjust txqueuelen based
> >> on number of queues created. (Well the default txqueuelen of
> >> 500/TUN_READQ_SIZE already seems too small even for single queue.)
> >
> > Hi Jerry:
> >
> > Do you have some test result of this? Anyway, tun allows userspace to
> > adjust this value based on its requirement.
> 
> Sure, but the default size of 500 is just way too small. queue overflows even
> with a simple single-stream throughput test through Openvswitch due to CPU
> scheduler anomaly. On our loaded multi-stream test even 8192 can't prevent
> queue overflow. But then with 8192 we'll be deep into the "buffer
> bloat" territory.
> We haven't figured out an optimal strategy for thruput vs latency, but
> suffice to
> say 500 is too small.
> 
> Jerry

Maybe TSO is off for you?
With TSO you can get 64Kbyte packets, 500 of these is 30 Mbytes!
We really should consider setting byte limits, not packet limits.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html