netdev - Re: [PATCH v2 1/1] alx: add a simple AR816x/AR817x device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jun 2013 22:39:18 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	netdev@...r.kernel.org, mcgrof@...not-panic.com, kvalo@...rom.com,
	adrian.chadd@...il.com, Johannes Stezenbach <js@...21.net>
Subject: Re: [PATCH v2 1/1] alx: add a simple AR816x/AR817x device driver

On Fri, 2013-06-21 at 22:42 +0200, Johannes Berg wrote:
> On Fri, 2013-06-21 at 13:45 +0100, Ben Hutchings wrote:
> 
> > > Ok, I can kick out the 'select NET_CORE' here anyway as MDIO doesn't
> > > need it. Or did you want to do a more general cleanup on this, then I'll
> > > leave it to you?
> > 
> > See commit a1606c7dc64d8449676d7e840dd2cd0c4e0a0c57.
> 
> Ok, I'll remove it from alx.
> 
> > > How would I even test that? Find random devices that have flow control?
> > > I don't think I have anything that would be programmable, unless I don't
> > > know about it being so :-)
> > 
> > Most Ethernet controllers seem to support flow control.  Though, in a
> > quick test, the e1000e driver on my laptop never seems to turn off Pause
> > advertising!
> 
> Hah! And how did you determine that? :)

Turned pause autoneg on/off and looked at the PHY registers with
mii-tool (Debian version, which I think has some patches that never went
upstream).

Ben.

-- 
Ben Hutchings
Klipstein's 4th Law of Prototyping and Production:
                                    A fail-safe circuit will destroy others.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)