netdev - Re: [PATCH net-next 07/11] net/mlx4_en: Add prints when TX timeout occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jun 2013 08:31:49 +0300
From:	Amir Vadai <amirv.mellanox@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Amir Vadai <amirv@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Eugenia Emantayev <eugenia@...lanox.com>
Subject: Re: [PATCH net-next 07/11] net/mlx4_en: Add prints when TX timeout
 occurs

On 20/06/2013 22:55, Joe Perches wrote:
> On Thu, 2013-06-20 at 22:40 +0300, Amir Vadai wrote:
>> From: Yevgeny Petrilin <yevgenyp@...lanox.com>
>>
>> Debug prints when a TX timeout is detected
> []
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
> []
>> @@ -1236,10 +1236,21 @@ static void mlx4_en_tx_timeout(struct net_device *dev)
> []
>> +	for (i = 0; i < priv->tx_ring_num; i++) {
>> +		if (!netif_tx_queue_stopped(netdev_get_tx_queue(dev, i)))
>> +			continue;
>> +		en_info(priv, "TX timeout detected on queue: %d,\n"
>> +			"QP: 0x%x, CQ: 0x%x,\n"
>> +			"Cons index: 0x%x, Prod index: 0x%x\n", i,
> 
> Not at dbg level and probably better on a single line.
> 

Will be fixed in v1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html