netdev - Re: VLAN driver question

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jun 2013 16:42:31 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jim Baxter <jim_baxter@...tor.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: VLAN driver question

On Thu, 2013-06-20 at 20:05 +0100, Jim Baxter wrote:
[...]
> Thank you for that information, I have decided to extract the data
> before copying the data into the skb->data structure.
> 
> This is the put of the packet showing my removal of the data correctly,
> however the network is not receiving any data on the VLAN.
> 
> - data buffer from the Network card
> ff ff ff ff ff ff 00 26 b9 d4 19 01 81 00 00 0a 08 06 00 01 08 00 06 04
> 00 01 00 26 b9 d4
> 
> - skb->data after I have only copied data to it and removed the vlan 4
> octet header using skb_copy_to_linear_data and
> skb_copy_to_linear_data_offset.
> ff ff ff ff ff ff 00 26 b9 d4 19 01 08 06 00 01 08 00 06 04 00 01 00 26
> b9 d4 19 01 c0 a8
> 
> - skb-data after eth_type_trans()
> 00 01 08 00 06 04 00 01 00 26 b9 d4 19 01 c0 a8 01 67 00 00 00 00 00 00
> c0 a8 01 64 00 00
> 
> After this point I send the packet into the network stack with:
> 	__vlan_hwaccel_put_tag(skb, htons(ETH_P_8021Q), vlan_tag);
> 
> 	napi_gro_receive(&fep->napi, skb);
> 
> Am I missing a kernel call or doing something wrong to cause the packet
> to be rejected in the kernel?

That looks about right to me, but perhaps vlan_tag has the wrong byte
order?  __vlan_hwaccel_put_tag() expects it in host byte order.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html