netdev - Re: [PATCH net-next] ipv6: split duplicate address detection and router solicitation timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Jun 2013 15:18:55 -0300
From:	Flavio Leitner <fbl@...hat.com>
To:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org,
	dlstevens@...ibm.com
Subject: Re: [PATCH net-next] ipv6: split duplicate address detection and
 router solicitation timer

On Sun, Jun 23, 2013 at 06:39:01PM +0200, Hannes Frederic Sowa wrote:
> This patch splits the timers for duplicate address detection and router
> solicitations apart. The router solicitations timer goes into inet6_dev
> and the dad timer stays in inet6_ifaddr.
> 
> The reason behind this patch is to reduce the number of unneeded router
> solicitations send out by the host if additional link-local addresses
> are created. Currently we send out RS for every link-local address on
> an interface.
> 
> If the RS timer fires we pick a source address with ipv6_get_lladdr. This
> change could hurt people adding additional link-local addresses and
> specifying these addresses in the radvd clients section because we
> no longer guarantee that we use every ll address as source address in
> router solicitations.
> 
> Cc: Flavio Leitner <fleitner@...hat.com>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Cc: David Stevens <dlstevens@...ibm.com>
> Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> ---

The patch looks good. I tried here and saw no bugs nor problems.

Reviewed-by: Flavio Leitner <fbl@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html