netdev - Re: [Patch net] ipv6,mcast: always hold idev->lock before mca

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Jun 2013 12:46:43 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org,
	Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch net] ipv6,mcast: always hold idev->lock before mca_lock

On Fri, Jun 28, 2013 at 02:26:07PM +0800, Ding Tianhong wrote:
> On 2013/6/27 11:42, Hannes Frederic Sowa wrote:
> > On Thu, Jun 27, 2013 at 11:09:44AM +0800, Cong Wang wrote:
> >> On Thu, 2013-06-27 at 00:58 +0200, Hannes Frederic Sowa wrote:
> >>> I do confirm that if this last hunk is applied the idev->addr_list
> >>> traversal
> >>> is safe.
> >>>
> >>> Please let me know if no one is working on this, I would rebase it
> >>> then. 
> >>
> >> I will rebase my patch on latest net-next. I am assuming this patch
> >> looks good to you...
> > 
> > Yes, I am fine with the apporach you took. Perhaps you could describe
> > why the non-idev-locked call to__ipv6_get_lladdr-call is ok in that place.
> > 
> > Thanks a lot,
> > 
> >   Hannes
> > 
> > 
> > 
> I think the problem is clear:
> 
> [...]
> 						
> so i think it is clear to describe the reason.

Sorry, I meant "...in a comment". ;)

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html