netdev - Re: [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Jul 2013 08:34:24 +0200
From:	Richard Weinberger <richard@....at>
To:	Chen Gang <gang.chen@...anux.com>
CC:	David Miller <davem@...emloft.net>, richardcochran@...il.com,
	netdev@...r.kernel.org, geert@...ux-m68k.org
Subject: Re: [PATCH] drivers/ptp/Kconfig: add "depends on HAS_IOMEM" for 'PTP_1588_CLOCK_PCH'

Am 01.07.2013 08:09, schrieb Chen Gang:
> On 07/01/2013 01:40 PM, Richard Weinberger wrote:
>> Am 01.07.2013 03:34, schrieb Chen Gang:
>>>> On 06/29/2013 12:23 PM, David Miller wrote:
>>>>>> From: Chen Gang <gang.chen@...anux.com>
>>>>>> Date: Thu, 27 Jun 2013 08:52:07 +0800
>>>>>>
>>>>>>>>>> @@ -73,6 +73,7 @@ config DP83640_PHY
>>>>>>>>>>  config PTP_1588_CLOCK_PCH
>>>>>>>>>>  	tristate "Intel PCH EG20T as PTP clock"
>>>>>>>>>>  	depends on X86 || COMPILE_TEST
>>>>>> This "depends on X86 || COMPILE_TEST" does not exist in either 'net' or 'net-next'.
>>>>>> Please submit your patches against a clean checkout of the networking GIT tree,
>>>>>> rather than something else such as linux-next.
>>>>
>>>> Oh, really it is, It is my fault (originally I get mail address from
>>>> "./scripts/get_maintainers.pl", but not give additional check on it).
>>>>
>>>> For your information (or implicit suggestion), if one module wants to
>>>> request 'COMPILE_TEST', the platforms (or asm-generic) is recommended to
>>>> try to support it.
>>>>
>>>> It seems I still have the chance to continue discuss about it with
>>>> platform guys. ;-)
>> David told you that your patch does not apply.
>> Not even Linus' tree has "depends on X86 || COMPILE_TEST".
>> Please adjust your patch.
> 
> 
> Before send the patch, it is better to discuss the "asm-generic"
> whether need consider 'COMPILE_TEST'.

No.

> config COMPILE_TEST
>         bool "Compile also drivers which will not load"
>         default n
>         help
>           Some drivers can be compiled on a different platform than they are
>           intended to be run on. Despite they cannot be loaded there (or even
>           when they load they cannot be used due to missing HW support),
>           developers still, opposing to distributors, might want to build such
>           drivers to compile-test them.
> 
>           If you are a developer and want to build everything available, say Y
>           here. If you are a user/distributor, say N here to exclude useless
>           drivers to be distributed.
> 
> I guess, 'COMPILE_TEST' is really useful for UML.

No.

We have explained you more than once what the deal and why UML does not
have ioremap() and friends.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html