netdev - Re: [PATCH v3] iwl3945: better skb management in rx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 1 Jul 2013 14:15:53 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Paul Stewart <pstew@...gle.com>,
	"John W. Linville" <linville@...driver.com>,
	"Steinar H. Gunderson" <sesse@...gle.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v3] iwl3945: better skb management in rx path

On Fri, Jun 28, 2013 at 08:05:06AM -0700, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
> 
> Steinar reported reallocations of skb->head with IPv6, leading to
> a warning in skb_try_coalesce()
> 
> It turns out iwl3945 has several problems :
> 
> 1) skb->truesize is underestimated. 
>    We really consume PAGE_SIZE bytes for a fragment,
>    not the frame length.
> 2) 128 bytes of initial headroom is a bit low and forces reallocations.
> 3) We can avoid consuming a full page for small enough frames.
> 
> Reported-by: Steinar H. Gunderson <sesse@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Paul Stewart <pstew@...gle.com>

Acked-by: Stanislaw Gruszka <sgruszka@...hat.com>

FYI, I'll post 4965 version soon.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html