netdev - PHC device sharing between PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jul 2013 17:56:08 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	linux-net-drivers <linux-net-drivers@...arflare.com>,
	netdev <netdev@...r.kernel.org>
Subject: PHC device sharing between PCI functions

Future Solarflare NICs may allow multiple PCI functions to make use of a
PTP hardware clock, but without a separate clock per function (probably
only one per controller).

I understand that shared PTP hardware clocks already exist, but they
usually have an independent existence as a separate PCI or platform
device.  In this case the clock would be accessible through any of the
PCI functions that also have a net device.

Options I see are:

1. Instantiate a clock only for the first function.  But that would
preclude making the clock available within multiple VMs and their host.

2. Keep track of controllers in the driver, and instantiate a clock
device for each function we see that is part of a controller we haven't
yet seen.  However, if that first function is subsequently passed-
through to a VM from its host, the host loses the clock (it can't be
reparented).

3. Keep track of controllers in the driver, instantiate a 'platform
device' for each of them, and instantiate a clock for each of them.
This is a little weird, as it wouldn't have any obvious association to
the PCI device hierarchy.  But it would let us control the lifetime of
the clock devices independently of any one function.

I prefer option 3 as I dislike introducing special cases, but I would be
interested to hear your (or other people's) opinion on this.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html