lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 01 Jul 2013 11:03:59 -0700
From:	Joe Perches <joe@...ches.com>
To:	Roland Dreier <roland@...nel.org>
Cc:	Or Gerlitz <or.gerlitz@...il.com>,
	Eli Cohen <eli@....mellanox.co.il>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Eli Cohen <eli@...lanox.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB
 devices

On Mon, 2013-07-01 at 10:49 -0700, Roland Dreier wrote:
> So I'm inclined to apply the mlx5 driver for 3.11, since it's a
> completely new driver.  However, reading through it so far I had the
> following comments, and I'd like these cleanups addressed along with
> Dave Miller's:
> 
> - The debug mask complexity seems unnecessary now that pr_debug() is
> controllable at runtime with the DYNAMIC_DEBUG stuff.  We should get
> rid of the extra level of indirection.

There's some value in block enabling/disabling messages
that dynamic_debug doesn't currently offer.

> - In:
> 
> +struct mlx5_cmd {
> ...
> +    struct mlx5_cmd_stats    stats[0x80a];
> 
> the 0x80a magic number really needs to have a name.

And that's a pretty big struct too.
2058 array entries. ~100kb
Does it really need to be that big?

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists